-
Notifications
You must be signed in to change notification settings - Fork 7.9k
GH-16187: fix ReflectionClass::__toString() with packed properties hash table #16192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good, but please target branch PHP-8.2. Bug fixes should always target the lowest applicable supported branch. |
aec48cc
to
7e53d41
Compare
Done, sorry for the spam of requesting review from code owners, when I switched the base branch Github included all of the commits since 8.2 until I force pushed (next time I'll try force pushing first) |
7e53d41
to
e678132
Compare
It's probably a good idea to echo the result of __toString. |
Normally I would agree, but
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, no properties is normal but the output is indeed long.
Anyway patch LGTM, I'll merge it tomorrow morning.
No description provided.